9fans archive / 1998 / 12 / 22 /    prev next

From: presotto@pla... presotto@pla...
Subject: [9fans] dnserver.c
Date: Wed, 16 Dec 1998 10:44:53 -0500

thanks

------ forwarded message follows ------

>From cse.psu.edu!owner-9fans Wed Dec 16 02:49:11 EST 1998
Received: from plan9.bell-labs.com ([135.104.9.2]) by plan9; Wed Dec 16 02:49:11 EST 1998
Received: from cse.psu.edu ([130.203.3.50]) by plan9; Wed Dec 16 02:49:04 EST 1998
Received: from localhost (majordom@localhost)
	by cse.psu.edu (8.8.8/8.8.8) with SMTP id CAA14098;
	Wed, 16 Dec 1998 02:48:57 -0500 (EST)
Received: by claven.cse.psu.edu (bulk_mailer v1.5); Wed, 16 Dec 1998 02:48:48 -0500
Received: (from majordom@localhost)
	by cse.psu.edu (8.8.8/8.8.8) id CAA14056
	for 9fans-outgoing; Wed, 16 Dec 1998 02:48:36 -0500 (EST)
X-Authentication-Warning: claven.cse.psu.edu: majordom set sender to owner-9fans using -f
Received: from ar.aichi-u.ac.jp (arisawa@ar.aichi-u.ac.jp [202.250.160.40])
	by cse.psu.edu (8.8.8/8.8.8) with SMTP id CAA14051
	for <9fans@cse...>; Wed, 16 Dec 1998 02:48:31 -0500 (EST)
Date: Wed, 16 Dec 1998 02:48:31 -0500 (EST)
From: arisawa@ar.aichi-u.ac.jp
Message-Id: <199812160748.CAA14051@cse...>
To: 9fans@cse...
Subject: [9fans] dnserver.c
Sender: owner-9fans@cse...
Reply-To: 9fans@cse...
Precedence: bulk

Hello 9fans!

It seems to me the following codes are buggy.
		len = read(fd, buf, sizeof(buf));
		getactivity();  /* this line is added by the boddle 811708952 */
		err = convM2DNS(&buf[Udphdrsize], len, &reqmsg);
 in dnsserver() in ndb/dnserver.c

I think they should be:
		len = read(fd, buf, sizeof(buf));
		getactivity();  /* this line is added by the boddle 811708952 */
		len -= Udphdrsize;
		err = convM2DNS(&buf[Udphdrsize], len, &reqmsg);


We can find similar codes in dnresolve.c
		len = read(fd, ibuf, Udphdrsize+Maxudp);
		alarm(0);
		len -= Udphdrsize;
		if(len < 0)
			return -1;	/* timed out */
		/* convert into internal format  */
		err = convM2DNS(&ibuf[Udphdrsize], len, mp);

Kenji Arisawa
E-mail: arisawa@aic...